Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 09cc73bb authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

scsi: csiostor: Uninitialized data in csio_ln_vnp_read_cbfn() 

[ Upstream commit f4875d509a0a78ad294a1a538d534b5ba94e685a ]

This variable is just a temporary variable, used to do an endian
conversion.  The problem is that the last byte is not initialized.  After
the conversion is completely done, the last byte is discarded so it doesn't
cause a problem.  But static checkers and the KMSan runtime checker can
detect the uninitialized read and will complain about it.

Link: https://lore.kernel.org/r/20211006073242.GA8404@kili


Fixes: 5036f0a0 ("[SCSI] csiostor: Fix sparse warnings.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent c9323d26

drivers/scsi/csiostor/csio_lnode.c

+1 −1
Original line number Diff line number Diff line
@@ -611,7 +611,7 @@ csio_ln_vnp_read_cbfn(struct csio_hw *hw, struct csio_mb *mbp) 
	struct fc_els_csp *csp;

	struct fc_els_cssp *clsp;

	enum fw_retval retval;

	__be32 nport_id;

	__be32 nport_id = 0;



	retval = FW_CMD_RETVAL_G(ntohl(rsp->alloc_to_len16));

	if (retval != FW_SUCCESS) {