Commit 4a8e70f5 authored Jul 29, 2015 by Dan Carpenter Committed by Jiri Kosina Jul 29, 2015

HID: uclogic: fix limit in uclogic_tablet_enable()



The limit should be ARRAY_SIZE(params) (5 elements) here instead of
sizeof(params) (20 bytes).

Fixes: 08177f40 ('HID: uclogic: merge hid-huion driver in hid-uclogic')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Nikolai Kondrashov <spbnick@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

parent 6debce6f

drivers/hid/hid-uclogic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -858,7 +858,7 @@ static int uclogic_tablet_enable(struct hid_device *hdev)
		for (p = drvdata->rdesc;
		p <= drvdata->rdesc + drvdata->rsize - 4;) {
		if (p[0] == 0xFE && p[1] == 0xED && p[2] == 0x1D &&
		p[3] < sizeof(params)) {
		p[3] < ARRAY_SIZE(params)) {
		v = params[p[3]];
		put_unaligned(cpu_to_le32(v), (s32 *)p);
		p += 4;