Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6debce6f authored by Antonio Borneo's avatar Antonio Borneo Committed by Jiri Kosina
Browse files

HID: cp2112: fix to force single data-report reply 



Current implementation of cp2112_raw_event() only accepts one data report at a
time. If last received data report is not fully handled yet, a new incoming
data report will overwrite it. In such case we don't guaranteed to propagate
the correct incoming data.

The trivial fix implemented here forces a single report at a time by requesting
in cp2112_read() no more than 61 byte of data, which is the payload size of a
single data report.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarAntonio Borneo <borneo.antonio@gmail.com>
Tested-by: default avatarEllen Wang <ellen@cumulusnetworks.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.com>
parent 9633920e

drivers/hid/hid-cp2112.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -356,6 +356,8 @@ static int cp2112_read(struct cp2112_device *dev, u8 *data, size_t size) 
	struct cp2112_force_read_report report;

	struct cp2112_force_read_report report;

	int ret;

	int ret;





	if (size > sizeof(dev->read_data))

		size = sizeof(dev->read_data);

	report.report = CP2112_DATA_READ_FORCE_SEND;

	report.report = CP2112_DATA_READ_FORCE_SEND;

	report.length = cpu_to_be16(size);

	report.length = cpu_to_be16(size);