Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47355b3c authored by Max Gurtovoy's avatar Max Gurtovoy Committed by Doug Ledford
Browse files

IB/core: Fix bit curruption in ib_device_cap_flags structure 



ib_device_cap_flags 64-bit expansion caused caps overlapping
and made consumers read wrong device capabilities. For example
IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
it to use a non-existing capability. This happened because signed
int becomes sign extended when converted it to u64. Fix this by
casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.

Fixes: f5aa9159 ('IB/core: Add arbitrary sg_list support')
Reported-by: default avatarRobert LeBlanc <robert@leblancnet.us>
Cc: Stable <stable@vger.kernel.org> #[v4.6+]
Acked-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Signed-off-by: default avatarMatan Barak <matanb@mellanox.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 8aec013a

include/rdma/ib_verbs.h

+1 −1
Original line number Diff line number Diff line
@@ -217,7 +217,7 @@ enum ib_device_cap_flags { 
	IB_DEVICE_CROSS_CHANNEL		= (1 << 27),

	IB_DEVICE_MANAGED_FLOW_STEERING		= (1 << 29),

	IB_DEVICE_SIGNATURE_HANDOVER		= (1 << 30),

	IB_DEVICE_ON_DEMAND_PAGING		= (1 << 31),

	IB_DEVICE_ON_DEMAND_PAGING		= (1ULL << 31),

	IB_DEVICE_SG_GAPS_REG			= (1ULL << 32),

	IB_DEVICE_VIRTUAL_FUNCTION		= ((u64)1 << 33),

	IB_DEVICE_RAW_SCATTER_FCS		= ((u64)1 << 34),