Commit 8aec013a authored Jun 04, 2016 by Mark Bloch Committed by Doug Ledford Jun 07, 2016

IB/core: Initialize sysfs attributes before sysfs create group



For dynamically allocated sysfs attributes there is a need to call
sysfs_attr_init in order to comply with lockdep, not calling it
will result in error complaining key is not in .data section.

Fixes: b40f4757 ("IB/core: Make device counter infrastructure dynamic")
Signed-off-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 9b29953b

drivers/infiniband/core/sysfs.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -925,10 +925,13 @@ static void setup_hw_stats(struct ib_device device, struct ib_port port,
		hsag->attrs[i] = alloc_hsa(i, port_num, stats->names[i]);
		if (!hsag->attrs[i])
		goto err;
		sysfs_attr_init(hsag->attrs[i]);
		}

		/* treat an error here as non-fatal */
		hsag->attrs[i] = alloc_hsa_lifespan("lifespan", port_num);
		if (hsag->attrs[i])
		sysfs_attr_init(hsag->attrs[i]);

		if (port) {
		struct kobject *kobj = &port->kobj;