Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44b0c738 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

[media] radio: fix error return code 

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent bfe40b79

drivers/media/radio/radio-timb.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -138,8 +138,10 @@ static int timbradio_probe(struct platform_device *pdev) 
		i2c_get_adapter(pdata->i2c_adapter), pdata->tuner, NULL);

		i2c_get_adapter(pdata->i2c_adapter), pdata->tuner, NULL);

	tr->sd_dsp = v4l2_i2c_new_subdev_board(&tr->v4l2_dev,

	tr->sd_dsp = v4l2_i2c_new_subdev_board(&tr->v4l2_dev,

		i2c_get_adapter(pdata->i2c_adapter), pdata->dsp, NULL);

		i2c_get_adapter(pdata->i2c_adapter), pdata->dsp, NULL);

	if (tr->sd_tuner == NULL || tr->sd_dsp == NULL)

	if (tr->sd_tuner == NULL || tr->sd_dsp == NULL) {

		err = -ENODEV;

		goto err_video_req;

		goto err_video_req;

	}





	tr->v4l2_dev.ctrl_handler = tr->sd_dsp->ctrl_handler;

	tr->v4l2_dev.ctrl_handler = tr->sd_dsp->ctrl_handler;