Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bfe40b79 authored by Julia Lawall's avatar Julia Lawall Committed by Mauro Carvalho Chehab
Browse files

[media] as102: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent 50f2468e
Loading
Loading
Loading
Loading
+1 −0
Original line number Original line Diff line number Diff line
@@ -337,6 +337,7 @@ int as102_dvb_register(struct as102_dev_t *as102_dev)
				       &as102_dev->bus_adap,
				       &as102_dev->bus_adap,
				       as102_dev->elna_cfg);
				       as102_dev->elna_cfg);
	if (!as102_dev->dvb_fe) {
	if (!as102_dev->dvb_fe) {
		ret = -ENODEV;
		dev_err(dev, "%s: as102_attach() failed: %d",
		dev_err(dev, "%s: as102_attach() failed: %d",
		    __func__, ret);
		    __func__, ret);
		goto efereg;
		goto efereg;