Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44467187 authored by Dan Rosenberg's avatar Dan Rosenberg Committed by David S. Miller
Browse files

drivers/net/eql.c: prevent reading uninitialized stack memory 



Fixed formatting (tabs and line breaks).

The EQL_GETMASTRCFG device ioctl allows unprivileged users to read 16
bytes of uninitialized stack memory, because the "master_name" member of
the master_config_t struct declared on the stack in eql_g_master_cfg()
is not altered or zeroed before being copied back to the user.  This
patch takes care of it.

Signed-off-by: default avatarDan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7011e660

drivers/net/eql.c

+2 −0
Original line number Diff line number Diff line
@@ -555,6 +555,8 @@ static int eql_g_master_cfg(struct net_device *dev, master_config_t __user *mcp) 
	equalizer_t *eql;

	master_config_t mc;



	memset(&mc, 0, sizeof(master_config_t));



	if (eql_is_master(dev)) {

		eql = netdev_priv(dev);

		mc.max_slaves = eql->max_slaves;