Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7011e660 authored by Dan Rosenberg's avatar Dan Rosenberg Committed by David S. Miller
Browse files

drivers/net/usb/hso.c: prevent reading uninitialized memory 



Fixed formatting (tabs and line breaks).

The TIOCGICOUNT device ioctl allows unprivileged users to read
uninitialized stack memory, because the "reserved" member of the
serial_icounter_struct struct declared on the stack in hso_get_count()
is not altered or zeroed before being copied back to the user.  This
patch takes care of it.

Signed-off-by: default avatarDan Rosenberg <dan.j.rosenberg@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e71895a1

drivers/net/usb/hso.c

+2 −0
Original line number Diff line number Diff line
@@ -1652,6 +1652,8 @@ static int hso_get_count(struct hso_serial *serial, 
	struct uart_icount cnow;

	struct hso_tiocmget  *tiocmget = serial->tiocmget;



	memset(&icount, 0, sizeof(struct serial_icounter_struct));



	if (!tiocmget)

		 return -ENOENT;

	spin_lock_irq(&serial->serial_lock);