Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 42347670 authored by Nuno Sa's avatar Nuno Sa Committed by Greg Kroah-Hartman
Browse files

iio: adis_buffer: do not return ints in irq handlers 



[ Upstream commit d877539ad8e8fdde9af69887055fec6402be1a13 ]

On an IRQ handler we should not return normal error codes as 'irqreturn_t'
is expected.

Not necessarily stable material as the old check cannot fail, so it's a bug
we can not hit.

Fixes: ccd2b52f ("staging:iio: Add common ADIS library")
Reviewed-by: default avatarAlexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: default avatarNuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210422101911.135630-2-nuno.sa@analog.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 157fec4a

drivers/iio/imu/adis_buffer.c

+0 −3
Original line number Diff line number Diff line
@@ -83,9 +83,6 @@ static irqreturn_t adis_trigger_handler(int irq, void *p) 
	struct adis *adis = iio_device_get_drvdata(indio_dev);

	int ret;



	if (!adis->buffer)

		return -ENOMEM;



	if (adis->data->has_paging) {

		mutex_lock(&adis->txrx_lock);

		if (adis->current_page != 0) {