Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 157fec4a authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

tty: nozomi: Fix a resource leak in an error handling function 



[ Upstream commit 31a9a318255960d32ae183e95d0999daf2418608 ]

A 'request_irq()' call is not balanced by a corresponding 'free_irq()' in
the error handling path, as already done in the remove function.

Add it.

Fixes: 9842c38e ("kfifo: fix warn_unused_result")
Reviewed-by: default avatarJiri Slaby <jirislaby@kernel.org>
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4f0d2b3038e82f081d370ccb0cade3ad88463fe7.1620580838.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 13abbb34

drivers/tty/nozomi.c

+1 −0
Original line number Diff line number Diff line
@@ -1479,6 +1479,7 @@ static int nozomi_card_init(struct pci_dev *pdev, 
		tty_unregister_device(ntty_driver, dc->index_start + i);

		tty_port_destroy(&dc->port[i].port);

	}

	free_irq(pdev->irq, dc);

err_free_kfifo:

	for (i = 0; i < MAX_PORT; i++)

		kfifo_free(&dc->port[i].fifo_ul);