Commit 13abbb34 authored Jun 25, 2021 by Pavel Skripkin Committed by Greg Kroah-Hartman Jul 20, 2021

net: sched: fix warning in tcindex_alloc_perfect_hash



[ Upstream commit 3f2db250099f46988088800052cdf2332c7aba61 ]

Syzbot reported warning in tcindex_alloc_perfect_hash. The problem
was in too big cp->hash, which triggers warning in kmalloc. Since
cp->hash comes from userspace, there is no need to warn if value
is not correct

Fixes: b9a24bb7 ("net_sched: properly handle failure case of tcf_exts_init()")
Reported-and-tested-by:  <syzbot+1071ad60cd7df39fdadb@syzkaller.appspotmail.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 91f805f9

net/sched/cls_tcindex.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -247,7 +247,7 @@ static int tcindex_alloc_perfect_hash(struct tcindex_data *cp)
		int i, err = 0;

		cp->perfect = kcalloc(cp->hash, sizeof(struct tcindex_filter_result),
		GFP_KERNEL);
		GFP_KERNEL \| __GFP_NOWARN);
		if (!cp->perfect)
		return -ENOMEM;