Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41aaa99f authored by Doug Ledford's avatar Doug Ledford
Browse files

IB/core: Fix array length allocation 



The new sysfs hw_counters code had an off by one in its array allocation
length.  Fix that and the comment along with it.

Reported-by: default avatarMark Bloch <markb@mellanox.com>
Fixes: b40f4757 (IB/core: Make device counter infrastructure
dynamic)
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 55c40648

drivers/infiniband/core/sysfs.c

+5 −2
Original line number Diff line number Diff line
@@ -901,9 +901,12 @@ static void setup_hw_stats(struct ib_device *device, struct ib_port *port, 
	if (!stats->names || stats->num_counters <= 0)

		goto err_free_stats;



	/*

	 * Two extra attribue elements here, one for the lifespan entry and

	 * one to NULL terminate the list for the sysfs core code

	 */

	hsag = kzalloc(sizeof(*hsag) +

		       // 1 extra for the lifespan config entry

		       sizeof(void *) * (stats->num_counters + 1),

		       sizeof(void *) * (stats->num_counters + 2),

		       GFP_KERNEL);

	if (!hsag)

		goto err_free_stats;