Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55c40648 authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford
Browse files

IB/hfi1: Suppress sparse warnings 



Avoid that sparse reports the following warnings for the hfi1 driver:

trace.c:217:13: warning: no previous prototype for ‘print_u64_array’ [-Wmissing-prototypes]
user_sdma.c:1361:17: warning: dubious: !x & y

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent d55215c5

drivers/infiniband/hw/hfi1/trace.c

+0 −13
Original line number Diff line number Diff line
@@ -214,19 +214,6 @@ const char *print_u32_array( 
	return ret;

}



const char *print_u64_array(

	struct trace_seq *p,

	u64 *arr, int len)

{

	int i;

	const char *ret = trace_seq_buffer_ptr(p);



	for (i = 0; i < len; i++)

		trace_seq_printf(p, "%s0x%016llx", i == 0 ? "" : " ", arr[i]);

	trace_seq_putc(p, 0);

	return ret;

}



__hfi1_trace_fn(PKT);

__hfi1_trace_fn(PROC);

__hfi1_trace_fn(SDMA);

drivers/infiniband/hw/hfi1/user_sdma.c

+2 −2
Original line number Diff line number Diff line
@@ -1355,11 +1355,11 @@ static int set_txreq_header(struct user_sdma_request *req, 
		 */

		SDMA_DBG(req, "TID offset %ubytes %uunits om%u",

			 req->tidoffset, req->tidoffset / req->omfactor,

			 !!(req->omfactor - KDETH_OM_SMALL));

			 req->omfactor != KDETH_OM_SMALL);

		KDETH_SET(hdr->kdeth.ver_tid_offset, OFFSET,

			  req->tidoffset / req->omfactor);

		KDETH_SET(hdr->kdeth.ver_tid_offset, OM,

			  !!(req->omfactor - KDETH_OM_SMALL));

			  req->omfactor != KDETH_OM_SMALL);

	}

done:

	trace_hfi1_sdma_user_header(pq->dd, pq->ctxt, pq->subctxt,