Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b45b8a7 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

memory: fsl_ifc: fix leak of private memory on probe failure 



[ Upstream commit 8e0d09b1232d0538066c40ed4c13086faccbdff6 ]

On probe error the driver should free the memory allocated for private
structure.  Fix this by using resource-managed allocation.

Fixes: a20cbdef ("powerpc/fsl: Add support for Integrated Flash Controller")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210527154322.81253-2-krzysztof.kozlowski@canonical.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d0d04b95

drivers/memory/fsl_ifc.c

+2 −2
Original line number Diff line number Diff line
@@ -109,7 +109,6 @@ static int fsl_ifc_ctrl_remove(struct platform_device *dev) 
	iounmap(ctrl->gregs);



	dev_set_drvdata(&dev->dev, NULL);

	kfree(ctrl);



	return 0;

}
@@ -221,7 +220,8 @@ static int fsl_ifc_ctrl_probe(struct platform_device *dev) 


	dev_info(&dev->dev, "Freescale Integrated Flash Controller\n");



	fsl_ifc_ctrl_dev = kzalloc(sizeof(*fsl_ifc_ctrl_dev), GFP_KERNEL);

	fsl_ifc_ctrl_dev = devm_kzalloc(&dev->dev, sizeof(*fsl_ifc_ctrl_dev),

					GFP_KERNEL);

	if (!fsl_ifc_ctrl_dev)

		return -ENOMEM;