Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 349259a3 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

dmaengine: ti: Add missing put_device in ti_dra7_xbar_route_allocate 



commit 615a4bfc426e11dba05c2cf343f9ac752fb381d2 upstream.

of_find_device_by_node() takes reference, we should use put_device()
to release it when not need anymore.

Fixes: a074ae38 ("dmaengine: Add driver for TI DMA crossbar on DRA7x")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20220605042723.17668-1-linmq006@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 452b9dfd

drivers/dma/ti-dma-crossbar.c

+4 −0
Original line number Diff line number Diff line
@@ -251,6 +251,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec, 
	if (dma_spec->args[0] >= xbar->xbar_requests) {

		dev_err(&pdev->dev, "Invalid XBAR request number: %d\n",

			dma_spec->args[0]);

		put_device(&pdev->dev);

		return ERR_PTR(-EINVAL);

	}
@@ -258,12 +259,14 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec, 
	dma_spec->np = of_parse_phandle(ofdma->of_node, "dma-masters", 0);

	if (!dma_spec->np) {

		dev_err(&pdev->dev, "Can't get DMA master\n");

		put_device(&pdev->dev);

		return ERR_PTR(-EINVAL);

	}



	map = kzalloc(sizeof(*map), GFP_KERNEL);

	if (!map) {

		of_node_put(dma_spec->np);

		put_device(&pdev->dev);

		return ERR_PTR(-ENOMEM);

	}
@@ -275,6 +278,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec, 
		dev_err(&pdev->dev, "Run out of free DMA requests\n");

		kfree(map);

		of_node_put(dma_spec->np);

		put_device(&pdev->dev);

		return ERR_PTR(-ENOMEM);

	}

	set_bit(map->xbar_out, xbar->dma_inuse);