Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 452b9dfd authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate 



commit c132fe78ad7b4ce8b5d49a501a15c29d08eeb23a upstream.

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not needed anymore.

Add missing of_node_put() in to fix this.

Fixes: ec9bfa1e ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220605042723.17668-2-linmq006@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent deb71c04

drivers/dma/ti-dma-crossbar.c

+1 −0
Original line number Diff line number Diff line
@@ -274,6 +274,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec, 
		mutex_unlock(&xbar->mutex);

		dev_err(&pdev->dev, "Run out of free DMA requests\n");

		kfree(map);

		of_node_put(dma_spec->np);

		return ERR_PTR(-ENOMEM);

	}

	set_bit(map->xbar_out, xbar->dma_inuse);