Commit 2bbb222a authored Nov 17, 2022 by ruanjinjie Committed by Greg Kroah-Hartman Jan 07, 2023

misc: tifm: fix possible memory leak in tifm_7xx1_switch_media()



[ Upstream commit fd2c930cf6a5b9176382c15f9acb1996e76e25ad ]

If device_register() returns error in tifm_7xx1_switch_media(),
name of kobject which is allocated in dev_set_name() called in device_add()
is leaked.

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Fixes: 2428a8fe ("tifm: move common device management tasks from tifm_7xx1 to tifm_core")
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20221117064725.3478402-1-ruanjinjie@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 5ea80d3d

drivers/misc/tifm_7xx1.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -194,7 +194,7 @@ static void tifm_7xx1_switch_media(struct work_struct *work)
	spin_unlock_irqrestore(&fm->lock, flags);		spin_unlock_irqrestore(&fm->lock, flags);
	}		}
	if (sock)		if (sock)
	tifm_free_device(&sock->dev);		put_device(&sock->dev);
	}		}
	spin_lock_irqsave(&fm->lock, flags);		spin_lock_irqsave(&fm->lock, flags);
	}		}