Commit 5ea80d3d authored Nov 23, 2022 by Yuan Can Committed by Greg Kroah-Hartman Jan 07, 2023

serial: sunsab: Fix error handling in sunsab_init()



[ Upstream commit 1a6ec673fb627c26e2267ca0a03849f91dbd9b40 ]

The sunsab_init() returns the platform_driver_register() directly without
checking its return value, if platform_driver_register() failed, the
allocated sunsab_ports is leaked.
Fix by free sunsab_ports and set it to NULL when platform_driver_register()
failed.

Fixes: c4d37215 ("[SERIAL] sunsab: Convert to of_driver framework.")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20221123061212.52593-1-yuancan@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 90ff030c

drivers/tty/serial/sunsab.c

+7 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1138,7 +1138,13 @@ static int __init sunsab_init(void)
	}		}
	}		}

	return platform_driver_register(&sab_driver);		err = platform_driver_register(&sab_driver);
			if (err) {
			kfree(sunsab_ports);
			sunsab_ports = NULL;
			}

			return err;
	}		}

	static void __exit sunsab_exit(void)		static void __exit sunsab_exit(void)