Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 102a39cb authored by Wenwen Wang's avatar Wenwen Wang Committed by Greg Kroah-Hartman
Browse files

wimax/i2400m: fix a memory leak bug 



[ Upstream commit 44ef3a03252844a8753479b0cea7f29e4a804bdc ]

In i2400m_barker_db_init(), 'options_orig' is allocated through kstrdup()
to hold the original command line options. Then, the options are parsed.
However, if an error occurs during the parsing process, 'options_orig' is
not deallocated, leading to a memory leak bug. To fix this issue, free
'options_orig' before returning the error.

Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 41cc386c

drivers/net/wimax/i2400m/fw.c

+3 −1
Original line number Diff line number Diff line
@@ -351,13 +351,15 @@ int i2400m_barker_db_init(const char *_options) 
			}

			result = i2400m_barker_db_add(barker);

			if (result < 0)

				goto error_add;

				goto error_parse_add;

		}

		kfree(options_orig);

	}

	return 0;



error_parse_add:

error_parse:

	kfree(options_orig);

error_add:

	kfree(i2400m_barker_db);

	return result;