Commit 41cc386c authored Aug 14, 2019 by Wenwen Wang Committed by Greg Kroah-Hartman Sep 10, 2019

net: kalmia: fix memory leaks



[ Upstream commit f1472cb09f11ddb41d4be84f0650835cb65a9073 ]

In kalmia_init_and_get_ethernet_addr(), 'usb_buf' is allocated through
kmalloc(). In the following execution, if the 'status' returned by
kalmia_send_init_packet() is not 0, 'usb_buf' is not deallocated, leading
to memory leaks. To fix this issue, add the 'out' label to free 'usb_buf'.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 08f7aa4e

drivers/net/usb/kalmia.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -117,16 +117,16 @@ kalmia_init_and_get_ethernet_addr(struct usbnet dev, u8 ethernet_addr)
		status = kalmia_send_init_packet(dev, usb_buf, sizeof(init_msg_1)
		/ sizeof(init_msg_1[0]), usb_buf, 24);
		if (status != 0)
		return status;
		goto out;

		memcpy(usb_buf, init_msg_2, 12);
		status = kalmia_send_init_packet(dev, usb_buf, sizeof(init_msg_2)
		/ sizeof(init_msg_2[0]), usb_buf, 28);
		if (status != 0)
		return status;
		goto out;

		memcpy(ethernet_addr, usb_buf + 10, ETH_ALEN);

		out:
		kfree(usb_buf);
		return status;
		}