Commit 081192b2 authored Sep 11, 2013 by David Daney Committed by Linus Torvalds Sep 11, 2013

up.c: use local_irq_{save,restore}() in smp_call_function_single.



The SMP version of this function doesn't unconditionally enable irqs, so
neither should this !SMP version.  There are no know problems caused by
this, but we make the change for consistency's sake.

Signed-off-by: David Daney <david.daney@cavium.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent fa688207

kernel/up.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -10,11 +10,13 @@
		int smp_call_function_single(int cpu, void (func) (void info), void *info,
		int wait)
		{
		unsigned long flags;

		WARN_ON(cpu != 0);

		local_irq_disable();
		(func)(info);
		local_irq_enable();
		local_irq_save(flags);
		func(info);
		local_irq_restore(flags);

		return 0;
		}