Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 008d0cf1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Ralf Baechle
Browse files

MIPS: Octeon: Off by one in octeon_irq_gpio_map() 



It should be >= ARRAY_SIZE() instead of > ARRAY_SIZE().

Fixes: 64b139f9 ('MIPS: OCTEON: irq: add CIB and other fixes')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarDavid Daney <david.daney@cavium.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-mips@linux-mips.org
Cc: kernel-janitors@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/13813/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent b4e76f7e

arch/mips/cavium-octeon/octeon-irq.c

+1 −1
Original line number Diff line number Diff line
@@ -1260,7 +1260,7 @@ static int octeon_irq_gpio_map(struct irq_domain *d, 


	line = (hw + gpiod->base_hwirq) >> 6;

	bit = (hw + gpiod->base_hwirq) & 63;

	if (line > ARRAY_SIZE(octeon_irq_ciu_to_irq) ||

	if (line >= ARRAY_SIZE(octeon_irq_ciu_to_irq) ||

		octeon_irq_ciu_to_irq[line][bit] != 0)

		return -EINVAL;