Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4e76f7e authored by Daniel Borkmann's avatar Daniel Borkmann Committed by Ralf Baechle
Browse files

bpf, mips: fix off-by-one in ctx offset allocation

Dan Carpenter reported [1] a static checker warning that ctx->offsets[]
may be accessed off by one from build_body(), since it's allocated with
fp->len * sizeof(*ctx.offsets) as length. The cBPF arm and ppc code
doesn't have this issue as claimed, so only mips seems to be affected and
should like most other JITs allocate with fp->len + 1. A few number of
JITs (x86, sparc, arm64) handle this differently, where they only require
fp->len array elements.

  [1] http://www.spinics.net/lists/mips/msg64193.html



Fixes: c6610de3 ("MIPS: net: Add BPF JIT")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: ast@kernel.org
Cc: linux-mips@linux-mips.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/13814/


Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 58a7e1c1
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -1199,7 +1199,7 @@ void bpf_jit_compile(struct bpf_prog *fp)

	memset(&ctx, 0, sizeof(ctx));

	ctx.offsets = kcalloc(fp->len, sizeof(*ctx.offsets), GFP_KERNEL);
	ctx.offsets = kcalloc(fp->len + 1, sizeof(*ctx.offsets), GFP_KERNEL);
	if (ctx.offsets == NULL)
		return;