Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e09bd36d authored by Pavan Chikkala's avatar Pavan Chikkala
Browse files

post_proc: reverb: send reverb params to DSP when effect is enabled 

Reverb effect is not getting enabled in DSP when client sets the preset
first and then enables the effect. reverb_enable call only sets the
enable flag and does not set the required params on DSP. This happens
in case of pcm offload playback. process_chain_l from playback thread
loop triggers the enable call on the respective effect and this call
need not always be set before any setParam call on the effect.

Fix is to enable in DSP as well when reverb is enabled by the user
and a valid preset is set. This way the order of setting preset and
enabling effect is not restricted

CRs-Fixed: 1056205

Change-Id: Ia4523e87537f174782727a05b356f21f42de1abf
parent bcffb663

post_proc/reverb.c

+11 −2
Original line number Original line Diff line number Diff line 
/*

/*

 * Copyright (c) 2013 - 2014, The Linux Foundation. All rights reserved.

 * Copyright (c) 2013 - 2014, 2016, The Linux Foundation. All rights reserved.

 * Not a Contribution.

 * Not a Contribution.

 *

 *

 * Copyright (C) 2013 The Android Open Source Project

 * Copyright (C) 2013 The Android Open Source Project
@@ -629,8 +629,17 @@ int reverb_enable(effect_context_t *context) 
        (reverb_ctxt->next_preset == REVERB_PRESET_NONE))

        (reverb_ctxt->next_preset == REVERB_PRESET_NONE))

        return 0;

        return 0;





    if (!offload_reverb_get_enable_flag(&(reverb_ctxt->offload_reverb)))

    if (!offload_reverb_get_enable_flag(&(reverb_ctxt->offload_reverb))) {

        offload_reverb_set_enable_flag(&(reverb_ctxt->offload_reverb), true);

        offload_reverb_set_enable_flag(&(reverb_ctxt->offload_reverb), true);

        if (reverb_ctxt->preset == true && reverb_ctxt->ctl)

            offload_reverb_send_params(reverb_ctxt->ctl, &reverb_ctxt->offload_reverb,

                                       OFFLOAD_SEND_REVERB_ENABLE_FLAG |

                                       OFFLOAD_SEND_REVERB_PRESET);

        if (reverb_ctxt->preset == true && reverb_ctxt->hw_acc_fd > 0)

            hw_acc_reverb_send_params(reverb_ctxt->hw_acc_fd, &reverb_ctxt->offload_reverb,

                                      OFFLOAD_SEND_REVERB_ENABLE_FLAG |

                                      OFFLOAD_SEND_REVERB_PRESET);

    }

    return 0;

    return 0;

}

}