Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1dd07994 authored by Ramjee Singh's avatar Ramjee Singh Committed by Gerrit - the friendly Code Review server
Browse files

policy_hal: Function prototype correction for custom policy 

- Ringtone is not heard when BT is connected because mute count
  for stream type ring is always greater then zero. The reason
  is when BT is connected duplicate output is created. Base policy
  does not handle mute count for duplicate output in stopSource
  properly. Custom policy stopSource handles this scenario but it
  is not called as signature does not match with base class
  stopSource

- Fix is to correct function signature for custom policy to make
  sure stopSource is called.

Change-Id: I8c0a99dbaae860a261ce2f15b6056d3d9c545568
parent cb47f05e

policy_hal/Android.mk

+1 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ ifeq ($(strip $(AUDIO_FEATURE_ENABLED_RECORD_PLAY_CONCURRENCY)),true) 
LOCAL_CFLAGS += -DRECORD_PLAY_CONCURRENCY

endif



LOCAL_CFLAGS += -Wno-error -fpermissive

LOCAL_MODULE := libaudiopolicymanager



include $(BUILD_SHARED_LIBRARY)

policy_hal/AudioPolicyManager.cpp

+4 −2
Original line number Diff line number Diff line
@@ -830,11 +830,12 @@ void AudioPolicyManagerCustom::setPhoneState(audio_mode_t state) 
        mLimitRingtoneVolume = false;

    }

}

status_t AudioPolicyManagerCustom::stopSource(sp<SwAudioOutputDescriptor> outputDesc,

status_t AudioPolicyManagerCustom::stopSource(sp<AudioOutputDescriptor> outputDesc1,

                                            audio_stream_type_t stream,

                                            bool forceDeviceUpdate)

{

    // always handle stream stop, check which stream type is stopping

    sp<SwAudioOutputDescriptor> outputDesc = (sp<SwAudioOutputDescriptor>) outputDesc1;

    handleEventForBeacon(stream == AUDIO_STREAM_TTS ? STOPPING_BEACON : STOPPING_OUTPUT);



    // handle special case for sonification while in call
@@ -885,13 +886,14 @@ status_t AudioPolicyManagerCustom::stopSource(sp<SwAudioOutputDescriptor> output 
        return INVALID_OPERATION;

    }

}

status_t AudioPolicyManagerCustom::startSource(sp<SwAudioOutputDescriptor> outputDesc,

status_t AudioPolicyManagerCustom::startSource(sp<AudioOutputDescriptor> outputDesc1,

                                             audio_stream_type_t stream,

                                             audio_devices_t device,

                                             uint32_t *delayMs)

{

    // cannot start playback of STREAM_TTS if any other output is being used

    uint32_t beaconMuteLatency = 0;

    sp<SwAudioOutputDescriptor> outputDesc = (sp<SwAudioOutputDescriptor>) outputDesc1;



    *delayMs = 0;

    if (stream == AUDIO_STREAM_TTS) {

policy_hal/AudioPolicyManager.h

+2 −2
Original line number Diff line number Diff line
@@ -100,11 +100,11 @@ protected: 


        // if argument "device" is different from AUDIO_DEVICE_NONE,  startSource() will force

        // the re-evaluation of the output device.

        status_t startSource(sp<SwAudioOutputDescriptor> outputDesc,

        status_t startSource(sp<AudioOutputDescriptor> outputDesc,

                             audio_stream_type_t stream,

                             audio_devices_t device,

                             uint32_t *delayMs);

         status_t stopSource(sp<SwAudioOutputDescriptor> outputDesc,

        status_t stopSource(sp<AudioOutputDescriptor> outputDesc,

                            audio_stream_type_t stream,

                            bool forceDeviceUpdate);

        // event is one of STARTING_OUTPUT, STARTING_BEACON, STOPPING_OUTPUT, STOPPING_BEACON   313