Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
Calendar
Calendar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Merge Requests 2
    • Merge Requests 2
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Commits
  • e
  • apps
  • CalendarCalendar
  • Merge Requests
  • !37

Open
Opened Apr 08, 2021 by Seweryn Fornalik@s3w3rynDeveloper4 of 7 tasks completed4/7 tasks
  • Report abuse
Report abuse

Fix issue#2899 - background not centered

  • Overview 6
  • Commits 2
  • Changes 2

Description

After recent UI changes there was some minor issue with the circled background, presented on the months related screens, that is kept centered in relation to the foreground number.

Related issues

e/backlog#2899

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Related MRs

None

How has this been tested?

This issue is device dependent and can be observed on the device with very high screen density. I tested it on my Samsung A5, but failed to spot the problem.

I've changed some /e/OS related configuration and managed to run the app on the Android emulator, on Pixel 4 XL, where I could reproduce the issue. This enabled me to analyze the problem and fix it.

In order to verify the fix run the app on a device that is known to have this issue, and choose "Month" option from a navigation drawer. Current day of month should be highlighted and centered inside circular background.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Edited Apr 08, 2021 by Seweryn Fornalik
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: e/apps/calendar!37
Source branch: Issue-2899/Fix_not_centered_background