Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 6873c03a authored by Simon Chan's avatar Simon Chan
Browse files

refactor: mark immutable array parameters as readonly

parent 40a60ca1

libraries/adb-daemon-webusb/src/device.ts

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ export const AdbDefaultInterfaceFilter = { 
} as const satisfies UsbInterfaceFilter;



export function mergeDefaultAdbInterfaceFilter(

    filters: USBDeviceFilter[] | undefined,

    filters: readonly USBDeviceFilter[] | undefined,

): (USBDeviceFilter & UsbInterfaceFilter)[] {

    if (!filters || filters.length === 0) {

        return [AdbDefaultInterfaceFilter];

libraries/adb-daemon-webusb/src/manager.ts

+3 −3
Original line number Diff line number Diff line
@@ -7,8 +7,8 @@ import { isErrorName, matchFilters } from "./utils.js"; 


export namespace AdbDaemonWebUsbDeviceManager {

    export interface RequestDeviceOptions {

        filters?: USBDeviceFilter[] | undefined;

        exclusionFilters?: USBDeviceFilter[] | undefined;

        filters?: readonly USBDeviceFilter[] | undefined;

        exclusionFilters?: readonly USBDeviceFilter[] | undefined;

    }

}
@@ -44,7 +44,7 @@ export class AdbDaemonWebUsbDeviceManager { 
        try {

            const device = await this.#usbManager.requestDevice({

                filters,

                exclusionFilters: options.exclusionFilters,

                exclusionFilters: options.exclusionFilters as USBDeviceFilter[],

            });



            const interface_ = matchFilters(

libraries/adb-daemon-webusb/src/observer.ts

+2 −2
Original line number Diff line number Diff line
@@ -25,8 +25,8 @@ export class AdbDaemonWebUsbDeviceObserver 
        return new AdbDaemonWebUsbDeviceObserver(usb, devices, options);

    }



    readonly #filters: (USBDeviceFilter & UsbInterfaceFilter)[];

    readonly #exclusionFilters?: USBDeviceFilter[] | undefined;

    readonly #filters: readonly (USBDeviceFilter & UsbInterfaceFilter)[];

    readonly #exclusionFilters?: readonly USBDeviceFilter[] | undefined;

    readonly #usbManager: USB;



    readonly #onDeviceAdd = new EventEmitter<

libraries/adb-daemon-webusb/src/utils.ts

+7 −7
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ export function getSerialNumber(device: USBDevice) { 
 *

 * ADB interface only has two endpoints, one for input and one for output.

 */

export function findUsbEndpoints(endpoints: USBEndpoint[]) {

export function findUsbEndpoints(endpoints: readonly USBEndpoint[]) {

    if (endpoints.length === 0) {

        throw new TypeError("No endpoints given");

    }
@@ -153,18 +153,18 @@ export function matchFilter( 


export function matchFilters(

    device: USBDevice,

    filters: (USBDeviceFilter & UsbInterfaceFilter)[],

    exclusionFilters?: USBDeviceFilter[],

    filters: readonly (USBDeviceFilter & UsbInterfaceFilter)[],

    exclusionFilters?: readonly USBDeviceFilter[],

): UsbInterfaceIdentifier | false;

export function matchFilters(

    device: USBDevice,

    filters: USBDeviceFilter[],

    exclusionFilters?: USBDeviceFilter[],

    filters: readonly USBDeviceFilter[],

    exclusionFilters?: readonly USBDeviceFilter[],

): boolean;

export function matchFilters(

    device: USBDevice,

    filters: USBDeviceFilter[],

    exclusionFilters?: USBDeviceFilter[],

    filters: readonly USBDeviceFilter[],

    exclusionFilters?: readonly USBDeviceFilter[],

): UsbInterfaceIdentifier | boolean {

    if (exclusionFilters && exclusionFilters.length > 0) {

        if (matchFilters(device, exclusionFilters)) {

libraries/adb-scrcpy/src/client.ts

+2 −2
Original line number Diff line number Diff line
@@ -57,9 +57,9 @@ function concatStreams<T>(...streams: ReadableStream<T>[]): ReadableStream<T> { 
}



export class AdbScrcpyExitedError extends Error {

    output: string[];

    output: readonly string[];



    constructor(output: string[]) {

    constructor(output: readonly string[]) {

        super("scrcpy server exited prematurely");

        this.output = output;

    }