Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa5cda82 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "sf: Fix issue with dequeueBuffer when multiple display present"

parents 8729d923 0560e0e8

services/surfaceflinger/DisplayHardware/HWC2.cpp

+1 −1
Original line number Diff line number Diff line
@@ -470,7 +470,7 @@ Error Display::getName(std::string* outName) const 


Error Display::getRequests(HWC2::DisplayRequest* outDisplayRequests,

                           std::unordered_map<HWC2::Layer*, LayerRequest>* outLayerRequests) {

    uint32_t intDisplayRequests;

    uint32_t intDisplayRequests = 0;

    std::vector<Hwc2::Layer> layerIds;

    std::vector<uint32_t> layerRequests;

    auto intError = mComposer.getDisplayRequests(

services/surfaceflinger/SurfaceFlinger.cpp

+10 −0
Original line number Diff line number Diff line
@@ -3415,6 +3415,7 @@ bool SurfaceFlinger::doComposeSurfaces(const sp<DisplayDevice>& displayDevice, 
    const Region bounds(displayState.bounds);

    const DisplayRenderArea renderArea(displayDevice);

    const bool hasClientComposition = getHwComposer().hasClientComposition(displayId);

    const bool hasFlipClientTargetRequest = getHwComposer().hasFlipClientTargetRequest(displayId);

    ATRACE_INT("hasClientComposition", hasClientComposition);



    bool applyColorMatrix = false;
@@ -3480,6 +3481,15 @@ bool SurfaceFlinger::doComposeSurfaces(const sp<DisplayDevice>& displayDevice, 
        if (applyColorMatrix) {

            clientCompositionDisplay.colorTransform = displayState.colorTransformMat;

        }

    } else if (hasFlipClientTargetRequest) {

        buf = display->getRenderSurface()->dequeueBuffer(&fd);



        if (buf == nullptr) {

            ALOGW("Dequeuing buffer for display [%s] failed, bailing out of "

                  "client composition for this frame",

                  displayDevice->getDisplayName().c_str());

            return false;

        }

    }



    /*