Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f7bd574b authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder_ndk: document env must not be null. 

The current implementation does not check that env is null, even though
the documentation suggests this. Updating the documentation since if we
fix this, and apps rely on it, it could cause compatibility problems
with old devices.

Bug: N/A
Test: N/A
Change-Id: I103345afc8783be7f69b5cfd30aac90a02488f72
parent 7c615582

libs/binder/ndk/include_ndk/android/binder_ibinder_jni.h

+5 −5
Original line number Diff line number Diff line
@@ -36,13 +36,13 @@ __BEGIN_DECLS 
/**

 * Converts an android.os.IBinder object into an AIBinder* object.

 *

 * If either env or the binder is null, null is returned. If this binder object was originally an

 * If the binder is null, null is returned. If this binder object was originally an

 * AIBinder object, the original object is returned. The returned object has one refcount

 * associated with it, and so this should be accompanied with an AIBinder_decStrong call.

 *

 * Available since API level 29.

 *

 * \param env Java environment.

 * \param env Java environment. Must not be null.

 * \param binder android.os.IBinder java object.

 *

 * \return an AIBinder object representing the Java binder object. If either parameter is null, or
@@ -54,12 +54,12 @@ __attribute__((warn_unused_result)) AIBinder* AIBinder_fromJavaBinder(JNIEnv* en 
/**

 * Converts an AIBinder* object into an android.os.IBinder object.

 *

 * If either env or the binder is null, null is returned. If this binder object was originally an

 * IBinder object, the original java object will be returned.

 * If the binder is null, null is returned. If this binder object was originally an IBinder object,

 * the original java object will be returned.

 *

 * Available since API level 29.

 *

 * \param env Java environment.

 * \param env Java environment. Must not be null.

 * \param binder the object to convert.

 *

 * \return an android.os.IBinder object or null if the parameters were null.