Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f37dcfbe authored by Vishnu Nair's avatar Vishnu Nair
Browse files

Initialize shadowRadius state 

The uninitialized var was causing the device to incorrectly going into glcomp.

Fixes: b/144450732
Test: adb shell am instrument -w -e class android.platform.test.scenario.launcher.FlingAllAppsMicrobenchmark android.platform.test.scenario/androidx.test.runner.AndroidJUnitRunner and capture a systrace
Change-Id: Ia33a4c8908990cd12fbd5a5ce1664ed96c112832
parent e6d829d9

services/surfaceflinger/Layer.cpp

+1 −0
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ Layer::Layer(const LayerCreationArgs& args) 
    mCurrentState.hasColorTransform = false;

    mCurrentState.colorSpaceAgnostic = false;

    mCurrentState.metadata = args.metadata;

    mCurrentState.shadowRadius = 0.f;



    // drawing state & current state are identical

    mDrawingState = mCurrentState;

services/surfaceflinger/Layer.h

+1 −1
Original line number Diff line number Diff line
@@ -950,7 +950,7 @@ private: 
    // The inherited shadow radius after taking into account the layer hierarchy. This is the

    // final shadow radius for this layer. If a shadow is specified for a layer, then effective

    // shadow radius is the set shadow radius, otherwise its the parent's shadow radius.

    float mEffectiveShadowRadius;

    float mEffectiveShadowRadius = 0.f;



    // Returns true if the layer can draw shadows on its border.

    virtual bool canDrawShadows() const { return true; }