Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f180f417 authored by Robin Lee's avatar Robin Lee
Browse files

Fix the bilinear filtering on the Skia blur 

We had bilinear sampling turned off when drawing the 0.25x sized texture
back to the framebuffer, so with blur enabled every 4x4 group of pixels
behind the blur was showing exactly the same. Ouch.

Test: Manual (see images in bug) - need to add a screenshot test
Fix: 174949985
Change-Id: I2233bc9d1b7c23ee37fba5ed5044b96c4ba4ec02
parent c53833d2

libs/renderengine/skia/SkiaGLRenderEngine.cpp

+5 −1
Original line number Diff line number Diff line
@@ -801,8 +801,12 @@ void SkiaGLRenderEngine::drawBlurRegion(SkCanvas* canvas, const BlurRegion& effe 


    SkPaint paint;

    paint.setAlpha(static_cast<int>(effectRegion.alpha * 255));

    const auto matrix = getBlurShaderTransform(canvas, layerRect);

    paint.setShader(blurredSurface->makeImageSnapshot()->makeShader(

            getBlurShaderTransform(canvas, layerRect)));

            SkTileMode::kClamp,

            SkTileMode::kClamp,

            SkSamplingOptions({SkFilterMode::kLinear, SkMipmapMode::kNone}),

            &matrix));



    auto rect = SkRect::MakeLTRB(effectRegion.left, effectRegion.top, effectRegion.right,

                                 effectRegion.bottom);