Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eff77c1f authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: scope down Parcel data in RPC transact 

We don't need (or want) to do more stuff in an error case.

Bug: 167966510
Test: binderRpcTest
Change-Id: I7a0b0b7f6b68c2fbd22f52b3888a9ed7b3179467
parent 6fde2dde

libs/binder/RpcState.cpp

+10 −9
Original line number Diff line number Diff line
@@ -498,19 +498,20 @@ status_t RpcState::processTransactInternal(const base::unique_fd& fd, 
        }

    }



    Parcel reply;

    reply.markForRpc(connection);



    if (replyStatus == OK) {

        Parcel data;

        // transaction->data is owned by this function. Parcel borrows this data and

        // only holds onto it for the duration of this function call. Parcel will be

        // deleted before the 'transactionData' object.

        data.ipcSetDataReference(transaction->data,

                                 transactionData.size() - offsetof(RpcWireTransaction, data),

                             nullptr /*object*/, 0 /*objectCount*/, do_nothing_to_transact_data);

                                 nullptr /*object*/, 0 /*objectCount*/,

                                 do_nothing_to_transact_data);

        data.markForRpc(connection);



    Parcel reply;

    reply.markForRpc(connection);



    if (replyStatus == OK) {

        if (target) {

            replyStatus = target->transact(transaction->code, data, &reply, transaction->flags);

        } else {