Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e6e08ab9 authored by Tianyu's avatar Tianyu
Browse files

Remove unused template 

Previously, code does not compile if using Post(fence) method. Error
message is no matching member function for call to 'Post',
frameworks/native/libs/vr/libbufferhub/include/private/dvr/buffer_hub_client.h:217:7:
note: candidate template ignored: couldn't infer template argument
'Meta'.

Test: use Post method in test and build on oc-dr1-daydream-dev branch.
Bug: None
Change-Id: Icc6977ec6b805d062cb3d0289c73fbf8b43ec940
parent 2a2ddfaf

libs/vr/libbufferhub/buffer_hub-test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -593,7 +593,7 @@ TEST_F(LibBufferHubTest, TestWithNoMeta) { 


  LocalHandle fence;



  EXPECT_EQ(0, p->Post<void>(LocalHandle()));

  EXPECT_EQ(0, p->Post(LocalHandle()));

  EXPECT_EQ(0, c->Acquire(&fence));

}

libs/vr/libbufferhub/include/private/dvr/buffer_hub_client.h

+1 −2
Original line number Diff line number Diff line
@@ -212,11 +212,10 @@ class BufferProducer : public pdx::ClientBase<BufferProducer, BufferHubBuffer> { 
  int Post(const LocalHandle& ready_fence, const void* meta,

           size_t user_metadata_size);



  template <typename Meta,

            typename = typename std::enable_if<std::is_void<Meta>::value>::type>

  int Post(const LocalHandle& ready_fence) {

    return Post(ready_fence, nullptr, 0);

  }



  template <typename Meta, typename = typename std::enable_if<

                               !std::is_void<Meta>::value>::type>

  int Post(const LocalHandle& ready_fence, const Meta& meta) {