Commit e2cff6af authored Sep 21, 2017 by Jeff Sharkey Committed by Andreas Gampe Oct 31, 2017

Skip children in fixupAppData() when parent shady.

If we find a directory with a shady GID, skip traversing into child
directories (if any), since we'll probably end up spamming the log
with every single item inside.

(cherry picked from commit 6b63b91f)

Test: builds, boots
Bug: 65852352
Merged-In: I8f03864adef572fc277e34e9f1589d9664fc75b3
Change-Id: I8f03864adef572fc277e34e9f1589d9664fc75b3

parent ec0afbfa

cmds/installd/InstalldNativeService.cpp

+3 −0

Original line number	Diff line number	Diff line
		@@ -714,6 +714,9 @@ binder::Status InstalldNativeService::fixupAppData(const std::unique_ptr<std::st
		// Ignore all other GID transitions, since they're kinda shady
		LOG(WARNING) << "Ignoring " << p->fts_path << " with unexpected GID " << actual
		<< " instead of " << expected;
		if (!(flags & FLAG_FORCE)) {
		fts_set(fts, p, FTS_SKIP);
		}
		}
		}
		}