Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit de288fe2 authored by Jesse Hall's avatar Jesse Hall
Browse files

Revert "bufferqueue: workaround: allow NULL fence with queueBuffer" 

Underlying bug has been fixed, workaround no longer needed

This reverts commit 5b0cbcf9.

Change-Id: Ic9532b407d1291a7780a12a75aaa117ae4aa9fcb
parent 7aa0c47e

libs/gui/BufferQueueProducer.cpp

+1 −6
Original line number Original line Diff line number Diff line
@@ -523,12 +523,7 @@ status_t BufferQueueProducer::queueBuffer(int slot, 




    if (fence == NULL) {

    if (fence == NULL) {

        BQ_LOGE("queueBuffer: fence is NULL");

        BQ_LOGE("queueBuffer: fence is NULL");

        // Temporary workaround for b/17946343: soldier-on instead of returning an error. This

        return BAD_VALUE;

        // prevents the client from dying, at the risk of visible corruption due to hwcomposer

        // reading the buffer before the producer is done rendering it. Unless the buffer is the

        // last frame of an animation, the corruption will be transient.

        fence = Fence::NO_FENCE;

        // return BAD_VALUE;

    }

    }





    switch (scalingMode) {

    switch (scalingMode) {