Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dd231e27 authored by Steven Moreland's avatar Steven Moreland
Browse files

binderRpcTest: sleeps /= 10 

This test takes too long now that we do many
combinations. Reduce sleeps, expose races.

Bug: 244325464
Test: binderRpcTest
Change-Id: I492f264b3d321a7df4b8876ea9afad9bedb02037
parent ec6c073a

libs/binder/tests/binderRpcTest.cpp

+5 −5
Original line number Diff line number Diff line
@@ -777,12 +777,12 @@ TEST_P(BinderRpc, ThreadPoolGreaterThanEqualRequested) { 
        ts.push_back(std::thread([&] { proc.rootIface->lockUnlock(); }));

    }



    usleep(100000); // give chance for calls on other threads

    usleep(10000); // give chance for calls on other threads



    // other calls still work

    EXPECT_EQ(OK, proc.rootBinder->pingBinder());



    constexpr size_t blockTimeMs = 500;

    constexpr size_t blockTimeMs = 50;

    size_t epochMsBefore = epochMillis();

    // after this, we should never see a response within this time

    EXPECT_OK(proc.rootIface->unlockInMsAsync(blockTimeMs));
@@ -1074,7 +1074,7 @@ TEST_P(BinderRpc, SingleDeathRecipient) { 
    }



    std::unique_lock<std::mutex> lock(dr->mMtx);

    ASSERT_TRUE(dr->mCv.wait_for(lock, 1000ms, [&]() { return dr->dead; }));

    ASSERT_TRUE(dr->mCv.wait_for(lock, 100ms, [&]() { return dr->dead; }));



    // need to wait for the session to shutdown so we don't "Leak session"

    EXPECT_TRUE(proc.proc.sessions.at(0).session->shutdownAndWait(true));
@@ -1109,7 +1109,7 @@ TEST_P(BinderRpc, SingleDeathRecipientOnShutdown) { 


    std::unique_lock<std::mutex> lock(dr->mMtx);

    if (!dr->dead) {

        EXPECT_EQ(std::cv_status::no_timeout, dr->mCv.wait_for(lock, 1000ms));

        EXPECT_EQ(std::cv_status::no_timeout, dr->mCv.wait_for(lock, 100ms));

    }

    EXPECT_TRUE(dr->dead) << "Failed to receive the death notification.";
@@ -1692,7 +1692,7 @@ TEST_P(BinderRpcServerOnly, Shutdown) { 


    bool shutdown = false;

    for (int i = 0; i < 10 && !shutdown; i++) {

        usleep(300 * 1000); // 300ms; total 3s

        usleep(30 * 1000); // 30ms; total 300ms

        if (server->shutdown()) shutdown = true;

    }

    ASSERT_TRUE(shutdown) << "server->shutdown() never returns true";