Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dcf469b0 authored by Shikha Malhotra's avatar Shikha Malhotra
Browse files

Check for ProjectID enablement made more performant 

Please see the ag/1947567 for more details on the original change of enabling project ids for internal storage
Bug: b/215154615
Test: atest installd/StorageHostTest
Test: atest installd/installd_service_test.cpp

Change-Id: Ib644005fa1936c778ded54a3da51b23a1eacc628
parent 7fa4f884

cmds/installd/InstalldNativeService.cpp

+14 −5
Original line number Diff line number Diff line
@@ -118,6 +118,12 @@ static constexpr const char* kMntFuse = "/mnt/pass_through/0/"; 


static std::atomic<bool> sAppDataIsolationEnabled(false);



/**

 * Flag to control if project ids are supported for internal storage

 */

static std::atomic<bool> sUsingProjectIdsFlag(false);

static std::once_flag flag;



namespace {



constexpr const char* kDump = "android.permission.DUMP";
@@ -461,11 +467,14 @@ done: 


static bool internal_storage_has_project_id() {

    // The following path is populated in setFirstBoot, so if this file is present

    // then project ids can be used.



    // then project ids can be used. Using call once to cache the result of this check

    // to avoid having to check the file presence again and again.

    std::call_once(flag, []() {

        auto using_project_ids =

                StringPrintf("%smisc/installd/using_project_ids", android_data_dir.c_str());

    return access(using_project_ids.c_str(), F_OK) == 0;

        sUsingProjectIdsFlag = access(using_project_ids.c_str(), F_OK) == 0;

    });

    return sUsingProjectIdsFlag;

}



static int prepare_app_dir(const std::string& path, mode_t target_mode, uid_t uid, gid_t gid,