lshal: remove unused "break". (d43d705c) · Commits · e / os / platform_frameworks_native

cmds/lshal/TableEntry.cpp

+20 −49

Original line number	Original line	Diff line number	Diff line
	@@ -44,75 +44,46 @@ static const std::string &getArchString(Architecture arch) {

	static std::string getTitle(TableColumnType type) {		static std::string getTitle(TableColumnType type) {
	switch (type) {		switch (type) {
	case TableColumnType::INTERFACE_NAME: {		case TableColumnType::INTERFACE_NAME: return "Interface";
	return "Interface";		case TableColumnType::TRANSPORT: return "Transport";
	} break;		case TableColumnType::SERVER_PID: return "Server";
	case TableColumnType::TRANSPORT: {		case TableColumnType::SERVER_CMD: return "Server CMD";
	return "Transport";		case TableColumnType::SERVER_ADDR: return "PTR";
	} break;		case TableColumnType::CLIENT_PIDS: return "Clients";
	case TableColumnType::SERVER_PID: {		case TableColumnType::CLIENT_CMDS: return "Clients CMD";
	return "Server";		case TableColumnType::ARCH: return "Arch";
	} break;		case TableColumnType::THREADS: return "Thread Use";
	case TableColumnType::SERVER_CMD: {		default:
	return "Server CMD";
	}
	case TableColumnType::SERVER_ADDR: {
	return "PTR";
	} break;
	case TableColumnType::CLIENT_PIDS: {
	return "Clients";
	} break;
	case TableColumnType::CLIENT_CMDS: {
	return "Clients CMD";
	} break;
	case TableColumnType::ARCH: {
	return "Arch";
	} break;
	case TableColumnType::THREADS: {
	return "Thread Use";
	} break;
	default: {
	LOG(FATAL) << "Should not reach here.";		LOG(FATAL) << "Should not reach here.";
	return "";		return "";
	}		}
	}		}
	}

	std::string TableEntry::getField(TableColumnType type) const {		std::string TableEntry::getField(TableColumnType type) const {
	switch (type) {		switch (type) {
	case TableColumnType::INTERFACE_NAME: {		case TableColumnType::INTERFACE_NAME:
	return interfaceName;		return interfaceName;
	} break;		case TableColumnType::TRANSPORT:
	case TableColumnType::TRANSPORT: {
	return transport;		return transport;
	} break;		case TableColumnType::SERVER_PID:
	case TableColumnType::SERVER_PID: {
	return serverPid == NO_PID ? "N/A" : std::to_string(serverPid);		return serverPid == NO_PID ? "N/A" : std::to_string(serverPid);
	} break;		case TableColumnType::SERVER_CMD:
	case TableColumnType::SERVER_CMD: {
	return serverCmdline;		return serverCmdline;
	} break;		case TableColumnType::SERVER_ADDR:
	case TableColumnType::SERVER_ADDR: {
	return serverObjectAddress == NO_PTR ? "N/A" : toHexString(serverObjectAddress);		return serverObjectAddress == NO_PTR ? "N/A" : toHexString(serverObjectAddress);
	} break;		case TableColumnType::CLIENT_PIDS:
	case TableColumnType::CLIENT_PIDS: {
	return join(clientPids, " ");		return join(clientPids, " ");
	} break;		case TableColumnType::CLIENT_CMDS:
	case TableColumnType::CLIENT_CMDS: {
	return join(clientCmdlines, ";");		return join(clientCmdlines, ";");
	} break;		case TableColumnType::ARCH:
	case TableColumnType::ARCH: {
	return getArchString(arch);		return getArchString(arch);
	} break;		case TableColumnType::THREADS:
	case TableColumnType::THREADS: {
	return getThreadUsage();		return getThreadUsage();
	} break;		default:
	default: {
	LOG(FATAL) << "Should not reach here.";		LOG(FATAL) << "Should not reach here.";
	return "";		return "";
	}		}
	}		}
	}

	TextTable Table::createTextTable(bool neat,		TextTable Table::createTextTable(bool neat,
	const std::function<std::string(const std::string&)>& emitDebugInfo) const {		const std::function<std::string(const std::string&)>& emitDebugInfo) const {