Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d37e6dd1 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: already sent checks abort 

Checked for a few weeks these logs weren't hit in any Android testing
environment. However, they have been hit and caused problems before.
Changing these to be fatal.

Fixes: 166282674
Test: boot
Change-Id: I069b0ab4d06c8bcc0edef76490d28b591066ad49
parent 936fc19a

libs/binder/Binder.cpp

+12 −12
Original line number Diff line number Diff line
@@ -319,7 +319,7 @@ bool BBinder::isRequestingSid() 


void BBinder::setRequestingSid(bool requestingSid)

{

    ALOGW_IF(mParceled,

    LOG_ALWAYS_FATAL_IF(mParceled,

                        "setRequestingSid() should not be called after a binder object "

                        "is parceled/sent to another process");
@@ -345,7 +345,7 @@ sp<IBinder> BBinder::getExtension() { 
}



void BBinder::setMinSchedulerPolicy(int policy, int priority) {

    ALOGW_IF(mParceled,

    LOG_ALWAYS_FATAL_IF(mParceled,

                        "setMinSchedulerPolicy() should not be called after a binder object "

                        "is parceled/sent to another process");
@@ -396,7 +396,7 @@ bool BBinder::isInheritRt() { 
}



void BBinder::setInheritRt(bool inheritRt) {

    ALOGW_IF(mParceled,

    LOG_ALWAYS_FATAL_IF(mParceled,

                        "setInheritRt() should not be called after a binder object "

                        "is parceled/sent to another process");
@@ -419,7 +419,7 @@ pid_t BBinder::getDebugPid() { 
}



void BBinder::setExtension(const sp<IBinder>& extension) {

    ALOGW_IF(mParceled,

    LOG_ALWAYS_FATAL_IF(mParceled,

                        "setExtension() should not be called after a binder object "

                        "is parceled/sent to another process");