Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1d644bd authored by Marissa Wall's avatar Marissa Wall
Browse files

createWithSurfaceParent: add logging 

There is a bug that we can't replicate in a test environment. These
added logs are to help us identify the root causes of the bug when
it happens in the field.

Test: compiles
Bug: 134888387
Change-Id: I0e9fe317ad8c6e65de30e5d9125252bef687d383
parent ccf624a3

services/surfaceflinger/Client.cpp

+7 −0
Original line number Diff line number Diff line
@@ -87,11 +87,18 @@ status_t Client::createWithSurfaceParent(const String8& name, uint32_t w, uint32 
                                         LayerMetadata metadata, sp<IBinder>* handle,

                                         sp<IGraphicBufferProducer>* gbp) {

    if (mFlinger->authenticateSurfaceTexture(parent) == false) {

        ALOGE("failed to authenticate surface texture");

        // The extra parent layer check below before returning is to help with debugging

        // b/134888387. Once the bug is fixed the check can be deleted.

        if ((static_cast<MonitoredProducer*>(parent.get()))->getLayer() == nullptr) {

            ALOGE("failed to find parent layer");

        }

        return BAD_VALUE;

    }



    const auto& layer = (static_cast<MonitoredProducer*>(parent.get()))->getLayer();

    if (layer == nullptr) {

        ALOGE("failed to find parent layer");

        return BAD_VALUE;

    }