Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0156d93 authored by Ana Krulec's avatar Ana Krulec
Browse files

Copy arguments into RenderEngineThreaded 

RenderEngineThreaded currently crashes when trying to create framebuffer
in function: createFramebufferImageIfNeeded. Looks like passing the copy
of arguments fixes the problem.

Bug: 157932582
Test: Print mFramebufferImageCacheSize, when threaded is off: 2
Test: Print mFramebufferImageCacheSize, when threaded is on: 2
Test: Open Chrome to trigger RE composition.
Test: Pull down status bar to trigger RE composition.
Change-Id: I3b21e0d159d63ea4454e46d10ffe698c4c1c3c4e
parent d84efff4

libs/renderengine/RenderEngine.cpp

+2 −3
Original line number Diff line number Diff line
@@ -41,9 +41,8 @@ std::unique_ptr<RenderEngine> RenderEngine::create(const RenderEngineCreationArg 
    switch (renderEngineType) {

        case RenderEngineType::THREADED:

            ALOGD("Threaded RenderEngine with GLES Backend");

            return renderengine::threaded::RenderEngineThreaded::create([&args]() {

                return android::renderengine::gl::GLESRenderEngine::create(args);

            });

            return renderengine::threaded::RenderEngineThreaded::create(

                    [args]() { return android::renderengine::gl::GLESRenderEngine::create(args); });

        case RenderEngineType::GLES:

        default:

            ALOGD("RenderEngine with GLES Backend");