Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cec2d8cc authored by Treehugger Robot's avatar Treehugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Add missing safety comments." into main

parents 6f4aa496 4c70edcf
Loading
Loading
Loading
Loading
+5 −0
Original line number Original line Diff line number Diff line
@@ -199,6 +199,7 @@ mod ahardwarebuffer_tests {
    #[test]
    #[test]
    #[should_panic]
    #[should_panic]
    fn take_from_raw_panics_on_null() {
    fn take_from_raw_panics_on_null() {
        // SAFETY: Passing a null pointer is safe, it should just panic.
        unsafe { AHardwareBuffer::take_from_raw(ptr::null_mut()) };
        unsafe { AHardwareBuffer::take_from_raw(ptr::null_mut()) };
    }
    }


@@ -216,9 +217,13 @@ mod ahardwarebuffer_tests {
        };
        };
        let mut raw_buffer_ptr = ptr::null_mut();
        let mut raw_buffer_ptr = ptr::null_mut();


        // SAFETY: The pointers are valid because they come from references, and
        // `AHardwareBuffer_allocate` doesn't retain them after it returns.
        let status = unsafe { ffi::AHardwareBuffer_allocate(&buffer_desc, &mut raw_buffer_ptr) };
        let status = unsafe { ffi::AHardwareBuffer_allocate(&buffer_desc, &mut raw_buffer_ptr) };
        assert_eq!(status, 0);
        assert_eq!(status, 0);


        // SAFETY: The pointer must be valid because it was just allocated successfully, and we
        // don't use it after calling this.
        let buffer = unsafe { AHardwareBuffer::take_from_raw(raw_buffer_ptr as *mut c_void) };
        let buffer = unsafe { AHardwareBuffer::take_from_raw(raw_buffer_ptr as *mut c_void) };
        assert_eq!(buffer.width(), 1024);
        assert_eq!(buffer.width(), 1024);
    }
    }