Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc7268a9 authored Nov 16, 2023 by Prabir Pradhan

Add TODOs to clean up tests that were duplicated for refactoring

Bug: 293587049
Bug: 311416205
Test: None
Change-Id: Ie7239faab63c63223f4199f7921ae2455ffb7896

parent ee6268f0

services/inputflinger/tests/GestureConverter_test.cpp

+2 −0

Original line number	Diff line number	Diff line
		@@ -1305,6 +1305,8 @@ TEST_F_WITH_FLAGS(GestureConverterTest, MoveEnablesTapToClick,
		ASSERT_FALSE(mReader->getContext()->isPreventingTouchpadTaps());
		}

		// TODO(b/311416205): De-duplicate the test cases after the refactoring is complete and the flagging
		// logic can be removed.
		class GestureConverterTestWithChoreographer : public GestureConverterTestBase {
		protected:
		void SetUp() override {

services/inputflinger/tests/InputReader_test.cpp

+2 −0

Original line number	Diff line number	Diff line
		@@ -4922,6 +4922,8 @@ TEST_F(CursorInputMapperTest, ConfigureDisplayId_IgnoresEventsForMismatchedPoint

		// --- CursorInputMapperTestWithChoreographer ---

		// TODO(b/311416205): De-duplicate the test cases after the refactoring is complete and the flagging
		// logic can be removed.
		class CursorInputMapperTestWithChoreographer : public CursorInputMapperTestBase {
		protected:
		void SetUp() override {

services/inputflinger/tests/TouchpadInputMapper_test.cpp

+2 −0

Original line number	Diff line number	Diff line
		@@ -176,6 +176,8 @@ protected:
		}
		};

		// TODO(b/311416205): De-duplicate the test cases after the refactoring is complete and the flagging
		// logic can be removed.
		/**
		* Start moving the finger and then click the left touchpad button. Check whether HOVER_EXIT is
		* generated when hovering stops. Currently, it is not.