Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb59156b authored by Steven Moreland's avatar Steven Moreland
Browse files

servicemanager: -= clients log spam 

This log was inverted when the patch was relanded. It
should almost never happen, but was causing ~300 lines
of logspam.

Bug: 210919187
Test: boot
Change-Id: Ic5fd6db2fe85b0aceb41a31d49520839a250edb8
parent 65fac116

cmds/servicemanager/ServiceManager.cpp

+7 −2
Original line number Diff line number Diff line
@@ -223,8 +223,13 @@ static bool meetsDeclarationRequirements(const sp<IBinder>& binder, const std::s 
#endif  // !VENDORSERVICEMANAGER



ServiceManager::Service::~Service() {

    if (!hasClients) {

        // only expected to happen on process death

    if (hasClients) {

        // only expected to happen on process death, we don't store the service

        // name this late (it's in the map that holds this service), but if it

        // is happening, we might want to change 'unlinkToDeath' to explicitly

        // clear this bit so that we can abort in other cases, where it would

        // mean inconsistent logic in servicemanager (unexpected and tested, but

        // the original lazy service impl here had that bug).

        LOG(WARNING) << "a service was removed when there are clients";

    }

}