Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5cd2073 authored by Jammy Yu's avatar Jammy Yu Committed by Shuzhen Wang
Browse files

Fix error BufferQueue attaching flow. 

Fix error BufferQueue attaching flow. Because BufferQueue attaching
buffer flow doesn't set mNeedsReallocation to false, it will case
Surface client to request buffer for attached buffer to cause unsync
buffer states with ACodec. So, for attaching buffer by Producer, we
need to set mNeedsReallocation to false in BufferQueue. And Surface
client will not request buffer again for attached buffer to cause
some missing frames.

Bug: 38238747
Issue: 34897483
Test: GTS
Change-Id: I25f9fff4b5d1f7052ab3be612cf34879fd17c27c
parent 2c201405

libs/gui/BufferQueueProducer.cpp

+1 −0
Original line number Diff line number Diff line
@@ -732,6 +732,7 @@ status_t BufferQueueProducer::attachBuffer(int* outSlot, 
    mSlots[*outSlot].mFence = Fence::NO_FENCE;

    mSlots[*outSlot].mRequestBufferCalled = true;

    mSlots[*outSlot].mAcquireCalled = false;

    mSlots[*outSlot].mNeedsReallocation = false;

    mCore->mActiveBuffers.insert(found);

    VALIDATE_CONSISTENCY();