Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b49b0b16 authored by Hridya Valsaraju's avatar Hridya Valsaraju
Browse files

lshal: read binder stats from binderfs 

If binderfs is mounted, lshal should read binder stats
from /dev/binderfs/binder_logs instead of debugfs.

Test: atest lshal_test, adb shell lshal
Change-Id: Id585cdcd71c0ab4346045a099c2e3d0ddffcecc0
parent 7cada579

cmds/lshal/ListCommand.cpp

+5 −2
Original line number Diff line number Diff line
@@ -206,10 +206,13 @@ VintfInfo ListCommand::getVintfInfo(const std::string& fqInstanceName, 
static bool scanBinderContext(pid_t pid,

        const std::string &contextName,

        std::function<void(const std::string&)> eachLine) {

    std::ifstream ifs("/d/binder/proc/" + std::to_string(pid));

    std::ifstream ifs("/dev/binderfs/binder_logs/proc/" + std::to_string(pid));

    if (!ifs.is_open()) {

        ifs.open("/d/binder/proc/" + std::to_string(pid));

        if (!ifs.is_open()) {

            return false;

        }

    }



    static const std::regex kContextLine("^context (\\w+)$");

cmds/lshal/ListCommand.h

+2 −1
Original line number Diff line number Diff line
@@ -104,7 +104,8 @@ protected: 
    Status fetchBinderizedEntry(const sp<::android::hidl::manager::V1_0::IServiceManager> &manager,

                                TableEntry *entry);



    // Get relevant information for a PID by parsing files under /d/binder.

    // Get relevant information for a PID by parsing files under

    // /dev/binderfs/binder_logs or /d/binder.

    // It is a virtual member function so that it can be mocked.

    virtual bool getPidInfo(pid_t serverPid, PidInfo *info) const;

    // Retrieve from mCachedPidInfos and call getPidInfo if necessary.