Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0fffdd1 authored by Siarhei Vishniakou's avatar Siarhei Vishniakou
Browse files

Improve InputTransport test coverage 

When sequence number is zero, then publicMotionEvent should return
BAD_VALUE. That check happens before the pointerCount check.
Therefore, this test does not currently fail due to a single
bad value of pointerCount, because it is also supplying an
invalid value for sequenceNumber. Use a valid sequenceNumber
value in this test, and add a separate test for bad value
of pointerCount.

Test: m -j libinput_tests_InputPublisherAndConsumer_test && adb push
out/target/product/$TARGET_PRODUCT/data/nativetest64/libinput_tests
/data/nativetest64
then run the binary on the target and check the output

Change-Id: I0d041870da81a1e7b95a1f83f822a0df15ee3a27
parent 8f258042

libs/input/tests/InputPublisherAndConsumer_test.cpp

+20 −3
Original line number Diff line number Diff line
@@ -254,19 +254,36 @@ TEST_F(InputPublisherAndConsumerTest, PublishMotionEvent_EndToEnd) { 
    ASSERT_NO_FATAL_FAILURE(PublishAndConsumeMotionEvent());

}



TEST_F(InputPublisherAndConsumerTest, PublishMotionEvent_WhenSequenceNumberIsZero_ReturnsError) {

    status_t status;

    const size_t pointerCount = 1;

    PointerProperties pointerProperties[pointerCount];

    PointerCoords pointerCoords[pointerCount];

    for (size_t i = 0; i < pointerCount; i++) {

        pointerProperties[i].clear();

        pointerCoords[i].clear();

    }



    status = mPublisher->publishMotionEvent(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

            pointerCount, pointerProperties, pointerCoords);

    ASSERT_EQ(BAD_VALUE, status)

            << "publisher publishMotionEvent should return BAD_VALUE";

}



TEST_F(InputPublisherAndConsumerTest, PublishMotionEvent_WhenPointerCountLessThan1_ReturnsError) {

    status_t status;

    const size_t pointerCount = 0;

    PointerProperties pointerProperties[pointerCount];

    PointerCoords pointerCoords[pointerCount];



    status = mPublisher->publishMotionEvent(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

    status = mPublisher->publishMotionEvent(1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

            pointerCount, pointerProperties, pointerCoords);

    ASSERT_EQ(BAD_VALUE, status)

            << "publisher publishMotionEvent should return BAD_VALUE";

}



TEST_F(InputPublisherAndConsumerTest, PublishMotionEvent_WhenPointerCountGreaterThanMax_ReturnsError) {

TEST_F(InputPublisherAndConsumerTest,

        PublishMotionEvent_WhenPointerCountGreaterThanMax_ReturnsError) {

    status_t status;

    const size_t pointerCount = MAX_POINTERS + 1;

    PointerProperties pointerProperties[pointerCount];
@@ -276,7 +293,7 @@ TEST_F(InputPublisherAndConsumerTest, PublishMotionEvent_WhenPointerCountGreater 
        pointerCoords[i].clear();

    }



    status = mPublisher->publishMotionEvent(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

    status = mPublisher->publishMotionEvent(1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,

            pointerCount, pointerProperties, pointerCoords);

    ASSERT_EQ(BAD_VALUE, status)

            << "publisher publishMotionEvent should return BAD_VALUE";