Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b025ca0c authored by Eric Laurent's avatar Eric Laurent
Browse files

Fix issue 1970108: crash in AudioFlinger::isMusicActive() 

Protected calls to MixerThread::isMusicActive() by AudioFlinger::mLock
parent 35da5ddb

libs/audioflinger/AudioFlinger.cpp

+9 −4
Original line number Diff line number Diff line
@@ -738,12 +738,13 @@ bool AudioFlinger::streamMute(int stream) const 


bool AudioFlinger::isMusicActive() const

{

    Mutex::Autolock _l(mLock);

 #ifdef WITH_A2DP

     if (isA2dpEnabled()) {

         return mA2dpMixerThread->isMusicActive();

         return mA2dpMixerThread->isMusicActive_l();

     }

 #endif

    return mHardwareMixerThread->isMusicActive();

    return mHardwareMixerThread->isMusicActive_l();

}



status_t AudioFlinger::setParameter(const char* key, const char* value)
@@ -1444,7 +1445,8 @@ bool AudioFlinger::MixerThread::streamMute(int stream) const 
    return mStreamTypes[stream].mute;

}



bool AudioFlinger::MixerThread::isMusicActive() const

// isMusicActive_l() must be called with AudioFlinger::mLock held

bool AudioFlinger::MixerThread::isMusicActive_l() const

{

    size_t count = mActiveTracks.size();

    for (size_t i = 0 ; i < count ; ++i) {
@@ -2030,7 +2032,10 @@ void AudioFlinger::MixerThread::OutputTrack::write(int16_t* data, uint32_t frame 
    inBuffer.i16 = data;

    

    if (mCblk->user == 0) {

        if (mOutputMixerThread->isMusicActive()) {

        mOutputMixerThread->mAudioFlinger->mLock.lock();

        bool isMusicActive = mOutputMixerThread->isMusicActive_l();

        mOutputMixerThread->mAudioFlinger->mLock.unlock();

        if (isMusicActive) {

            mCblk->forceReady = 1;

            LOGV("OutputTrack::start() force ready");

        } else if (mCblk->frameCount > frames){

libs/audioflinger/AudioFlinger.h

+1 −1
Original line number Diff line number Diff line
@@ -463,7 +463,7 @@ private: 
        virtual     float       streamVolume(int stream) const;

        virtual     bool        streamMute(int stream) const;



                    bool        isMusicActive() const;

                    bool        isMusicActive_l() const;

        

                    

                    sp<Track>   createTrack_l(