Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a509706c authored by Daniele Di Proietto's avatar Daniele Di Proietto
Browse files

Keep tracing session alive in fuzzer 

Commit 7e6446c3("Refactored surfaceflinger_frametracer_fuzzer")
added some more randomness to the fuzzer, but, by wrapping the
tracingSession unique_ptr into a block, also caused the tracing session
to be destoyed immediately.

Keeping the tracing session alive is important to exercise interesting
code path inside the fuzzed code. If the tracing session is dead,
tracing is effectively disabled and the tracing code in durface flinger
will not be covered.

Bug: 307601836
Change-Id: Ia1c4a76f09cf20fca56add4cab11a8cdfd579842
parent 42e79138

services/surfaceflinger/fuzzer/surfaceflinger_frametracer_fuzzer.cpp

+5 −1
Original line number Diff line number Diff line
@@ -115,11 +115,15 @@ void FrameTracerFuzzer::process() { 
    std::vector<int32_t> layerIds =

            generateLayerIds(mFdp.ConsumeIntegralInRange<size_t>(kMinLayerIds, kMaxLayerIds));



    std::unique_ptr<perfetto::TracingSession> tracingSession;

    while (mFdp.remaining_bytes()) {

        auto invokeFrametracerAPI = mFdp.PickValueInArray<const std::function<void()>>({

                [&]() { mFrameTracer->registerDataSource(); },

                [&]() {

                    auto tracingSession = getTracingSessionForTest();

                    if (tracingSession) {

                        tracingSession->StopBlocking();

                    }

                    tracingSession = getTracingSessionForTest();

                    tracingSession->StartBlocking();

                },

                [&]() { traceTimestamp(layerIds, layerIds.size()); },